Fix async generator handling #1844
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @sidux! Could you add a test? |
|
Ping @sidux |
|
@RobbeSneyders I'll take some time during this week to finish this |
|
Do you have time to add a test @sidux? |
|
@RobbeSneyders @chrisinmtown this PR is ready (sorry for the big delay) |
chrisinmtown
reviewed
Nov 4, 2025
connexion/decorators/response.py
Outdated
| """ | ||
| This method converts a handler response to a framework response. | ||
| The handler response can be a ConnexionResponse, a framework response, a tuple or an | ||
| object. |
There was a problem hiding this comment.
You might expand the comment here to add "or a coroutine".
chrisinmtown
reviewed
Nov 4, 2025
There was a problem hiding this comment.
This seems really useful, adding tests for the response decorators, which apparently were completely missing. I look forward to seeing the new code-coverage statistic when this runs at Github.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1842